Fast-DDS icon indicating copy to clipboard operation
Fast-DDS copied to clipboard

Setting vendor_id on received CacheChange_t [21214]

Open richiware opened this issue 1 year ago • 3 comments

Description

MessageReceiver is setting the vendor _id for all RTPS submessages but for Data and DataFrag. This PR sets the vendor_id for this last submessages.

@Mergifyio backport 2.14.x

Contributor Checklist

  • [x] Commit messages follow the project guidelines.
  • [x] The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • [x] Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • [x] Changes are API compatible.
  • [x] New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • [x] Applicable backports have been included in the description.

Reviewer Checklist

  • [x] The PR has a milestone assigned.
  • [x] The title and description correctly express the PR's purpose.
  • [ ] Check contributor checklist is correct.
  • [ ] Check CI results: changes do not issue any warning.
  • [ ] Check CI results: failing tests are unrelated with the changes.

richiware avatar Jun 21 '24 05:06 richiware

@Mergifyio backport 2.14.x

EduPonz avatar Jul 01 '24 10:07 EduPonz

backport 2.14.x

✅ Backports have been created

mergify[bot] avatar Jul 01 '24 10:07 mergify[bot]

We have internally decided to not provide tests for this simple change

EduPonz avatar Jul 03 '24 07:07 EduPonz

CI:

EduPonz avatar Jul 04 '24 08:07 EduPonz