Fast-DDS icon indicating copy to clipboard operation
Fast-DDS copied to clipboard

[21053] Move DR TypeConsistencyEnforcement & DataRepresentation from TypeConsistency to DataReaderQos

Open JesusPoderoso opened this issue 1 year ago • 3 comments

Description

This PR updates the DataReaderQoS reformatting the TypeConsistencyQos:

  1. DataReaderQos shall have:
    • TypeConsistencyEnforcementQosPolicy::type_consistency
    • DataRepresentationQosPolicy::representation
  2. DataReader::TypeConsistencyQos shall be removed

Contributor Checklist

  • [x] Commit messages follow the project guidelines.
  • [x] The code follows the style guidelines of this project.
  • [x] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [x] Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • [x] New feature has been added to the versions.md file (if applicable).
  • [x] New feature has been documented/Current behavior is correctly described in the documentation.
    • Related documentation PR: eProsima/Fast-DDS-docs#779
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • [x] The PR has a milestone assigned.
  • [x] The title and description correctly express the PR's purpose.
  • [x] Check contributor checklist is correct.
  • [x] Check CI results: changes do not issue any warning.
  • [x] Check CI results: failing tests are unrelated with the changes.

JesusPoderoso avatar May 21 '24 14:05 JesusPoderoso

As this PR is targeting 3.0.0, we can break API, which should be left unmarked in the checklist as this PR is breaking.

I think it is correctly checked, see following comment section of the PR template:

<!--
- If any of the elements of the following checklist is not applicable, substitute the checkbox [ ] by _N/A_:
- If any of the elements of the following checklist is not fulfilled on purpose, please provide a reason
  and substitute the checkbox [ ] with ❌: or __NO__:.
-->

JesusPoderoso avatar May 23 '24 06:05 JesusPoderoso

@richiprosima please test_3 this

Mario-DL avatar May 23 '24 13:05 Mario-DL

@richiprosima please test_3 windows

Mario-DL avatar May 24 '24 06:05 Mario-DL