Fast-DDS icon indicating copy to clipboard operation
Fast-DDS copied to clipboard

[20965] Fix Python Installation version in Github CI. Address failing system tests environment issues. (backport #4759)

Open mergify[bot] opened this issue 1 year ago • 3 comments

Description

This PR addresses failing github CI system tests.

  • It fixes Python installation version in Windows & Ubuntu Github CIs (macOs was already doing it).
  • Selects the appropriate python version in the launcher used in .bat tool files by means of an environment variable PYTHON_VERSION {Major.Minor}.
  • Prevents Qt from setting-up Python, as we are who manage the Python installation

Notes:

  • In windows, pywin32 is not listed as a required python package at the Python Dependencies step as it is a requirement of colcon and it is installed along with it.
  • Python version is not fixed in the sanitizers jobs since system tests are not run there.

Work done in #4731 precedes this PR.

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • [X] Commit messages follow the project guidelines.

  • [X] The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • N/A Changes are ABI compatible.

  • N/A Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • [X] Applicable backports have been included in the description.

Reviewer Checklist

  • [x] The PR has a milestone assigned.
  • [x] The title and description correctly express the PR's purpose.
  • [x] Check contributor checklist is correct.
  • [x] Check CI results: changes do not issue any warning.
  • [x] Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #4759 done by [Mergify](https://mergify.com).

mergify[bot] avatar May 09 '24 12:05 mergify[bot]

Cherry-pick of 3b2e781f3133460cfcce3a316d82ac6abed06302 has failed:

On branch mergify/bp/2.10.x/pr-4759
Your branch is up to date with 'origin/2.10.x'.

You are currently cherry-picking commit 3b2e781f3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/reusable-ubuntu-ci.yml
	modified:   .github/workflows/reusable-windows-ci.yml
	modified:   tools/fastdds/fastdds.bat
	modified:   tools/fastdds/ros-discovery.bat

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/system/tools/fastdds/CMakeLists.txt

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify[bot] avatar May 09 '24 12:05 mergify[bot]

Added cherry pick from #4447

Mario-DL avatar May 10 '24 06:05 Mario-DL

@Mario-DL Communication tests (based on python scripts) have failed both in Mac and Windows. Could you take a look?

MiguelCompany avatar May 10 '24 09:05 MiguelCompany

@mergifyio rebase

MiguelCompany avatar May 17 '24 05:05 MiguelCompany

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar May 17 '24 05:05 mergify[bot]

@richiprosima Please test windows

MiguelCompany avatar May 17 '24 08:05 MiguelCompany