[20732] Fix some leaks in XML DynamicTypes Parser (backport #4717) (backport #4735)
Description
This PR adds a regression test with the XML reported from OSS Fuzz, and performs the following two actions on every method parsing and registering a dynamic type:
#. Doing a pre-check on whether a type with the same name is already registered in the profile manager, and perform an early return in that case
#. Tell DynamicTypeBuilderFactory to delete the builder when a call to XMLProfileManager::insertDynamicTypeByName fails.
@Mergifyio backport 2.13.x 2.10.x 2.6.x
Contributor Checklist
-
[x] Commit messages follow the project guidelines.
-
[x] The code follows the style guidelines of this project.
-
[x] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
-
N/A Any new/modified methods have been properly documented using Doxygen.
-
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
-
[x] Changes are ABI compatible.
-
[x] Changes are API compatible.
-
N/A New feature has been added to the
versions.mdfile (if applicable). -
N/A New feature has been documented/Current behavior is correctly described in the documentation.
-
[x] Applicable backports have been included in the description.
Reviewer Checklist
- [x] The PR has a milestone assigned.
- [x] The title and description correctly express the PR's purpose.
- [x] Check contributor checklist is correct.
- [x] Check CI results: changes do not issue any warning.
- [x] Check CI results: failing tests are unrelated with the changes.
This is an automatic backport of pull request #4717 done by [Mergify](https://mergify.com).
This is an automatic backport of pull request #4735 done by [Mergify](https://mergify.com).
@richiprosima please test this
It seems that we need to refactor the logging macros to the old ones, could you take a look @MiguelCompany ?
@richiprosima Please test this
I think that we should not update Fast CDR thirdparty submodule, @MiguelCompany could you take a look it ?
@richiprosima please test this