[20351] Fix on_sample_lost notification on best-effort readers for framented samples (backport #4187)
Description
When some fragments are lost on every sample, best-effort readers were not notifying on_sample_lost events.
@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x
Contributor Checklist
-
[x] Commit messages follow the project guidelines.
-
[x] The code follows the style guidelines of this project.
-
[x] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
-
N/A Any new/modified methods have been properly documented using Doxygen.
-
[x] Changes are ABI compatible.
-
[x] Changes are API compatible.
-
N/A New feature has been added to the
versions.mdfile (if applicable). -
N/A New feature has been documented/Current behavior is correctly described in the documentation.
-
[x] Applicable backports have been included in the description.
Reviewer Checklist
- [x] The PR has a milestone assigned.
- [x] Check contributor checklist is correct.
- [ ] Check CI results: changes do not issue any warning.
- [ ] Check CI results: failing tests are unrelated with the changes.
This is an automatic backport of pull request #4187 done by [Mergify](https://mergify.com).
@richiprosima please test this
This one now depends on #4825
Sorry, saw the comment after requesting ci, I will abort and w8 for the other
@richiprosima please test discovery-server