Fast-DDS icon indicating copy to clipboard operation
Fast-DDS copied to clipboard

[20568] Remove all redundant headers from include/fastrtps

Open EduPonz opened this issue 11 months ago • 4 comments

Description

This PR removes all redundant headers from include/fastrtps. It makes UnitsParser private It depends on:

  • #4545

Discovery Server related PR:

  • eProsima/Discovery-Server#73

Contributor Checklist

  • [x] Commit messages follow the project guidelines.
  • [x] The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • ❌ Changes are ABI compatible.
  • ❌ Changes are API compatible.
  • [x] New feature has been added to the versions.md file (if applicable).
  • [x] New feature has been documented/Current behavior is correctly described in the documentation. Related documentation PR: eProsima/Fast-DDS-docs#737
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • [x] The PR has a milestone assigned.
  • [x] The title and description correctly express the PR's purpose.
  • [x] Check contributor checklist is correct.
  • [ ] Check CI results: changes do not issue any warning.
  • [ ] Check CI results: failing tests are unrelated with the changes.

EduPonz avatar Mar 11 '24 14:03 EduPonz

@richiprosima please test_3 this

elianalf avatar Mar 25 '24 14:03 elianalf

@richiprosima please test_3 this

elianalf avatar Mar 27 '24 07:03 elianalf

ASan workflow run with correct DS branch here

EduPonz avatar Mar 28 '24 08:03 EduPonz

We should create a Shapes-Demo branch with these changes, in particular the build failed because it couldn't find fastrtps/rtps/common/Guid.h

elianalf avatar Apr 29 '24 08:04 elianalf

@richiprosima please test_3 this

elianalf avatar May 16 '24 05:05 elianalf

LGTM with green CI

elianalf avatar May 16 '24 06:05 elianalf

@richiprosima please test_3 this

elianalf avatar May 20 '24 08:05 elianalf