Fast-DDS icon indicating copy to clipboard operation
Fast-DDS copied to clipboard

[20566] Migrate classes from include/fastrtps to fastdds

Open elianalf opened this issue 11 months ago • 2 comments

Related documentation PR: eProsima/Fast-DDS-docs#726 Related Discovery-Server PR: eProsima/Discovery-Server#72 Related Fast DDS GEN PR: eProsima/Fast-DDS-Gen#318

Description

This PR migrates the following classes from include/fastrtps to fastdds:

  • fastrtps/attributes/TopicAttributes.h
  • fastrtps/utils/collections
  • IPFinder.h
  • IPLocator.h
  • fixed_size_bitmap.hpp
  • md5.h
  • TimedConditionVariable.hpp
  • TimedMutex.hpp

Contributor Checklist

  • N/A Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • ❌ Changes are ABI compatible.
  • ❌ Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • [x] The PR has a milestone assigned.
  • [x] The title and description correctly express the PR's purpose.
  • [x] Check contributor checklist is correct.
  • [ ] Check CI results: changes do not issue any warning.
  • [ ] Check CI results: failing tests are unrelated with the changes.

elianalf avatar Mar 06 '24 10:03 elianalf

Documentation job is failing because this branch has been rebased on the top of [20569] Migrate DLL API exporter and auto linkage to fastdds, consequently it ereditated all the changes. The job uses the 3.0.x-devel branch of Fast DDS docs which doesn't have yet those changes, once the docs Migrate DLL API exporter to fastdds will be merged, the job must run again. This will probably apply to asan job as well for discovery server branch.

elianalf avatar Mar 07 '24 10:03 elianalf

asan-discovery-server is failing because the job uses the discovery-server default 3.0.x-devel branch instead of the corresponding branch

elianalf avatar Mar 13 '24 12:03 elianalf

EduPonz avatar Mar 22 '24 16:03 EduPonz

Docs CI passed here

elianalf avatar Mar 25 '24 10:03 elianalf