Fast-DDS icon indicating copy to clipboard operation
Fast-DDS copied to clipboard

[20335] DynamicTypeBuilderFactoryImpl::create_type_w_type_object implementation

Open JLBuenoLopez opened this issue 1 year ago • 6 comments

Description

This PR implements DynamicTypeBuilderFactoryImpl::create_type_w_type_object method. It also uses this feature to fix the DDS SQL Filter and its tests.

Contributor Checklist

  • [ ] Commit messages follow the project guidelines.
  • [ ] The code follows the style guidelines of this project.
  • [ ] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [ ] Any new/modified methods have been properly documented using Doxygen.
  • [ ] Changes are ABI compatible.
  • [ ] Changes are API compatible.
  • [ ] New feature has been added to the versions.md file (if applicable).
  • [ ] New feature has been documented/Current behavior is correctly described in the documentation.
  • [ ] Applicable backports have been included in the description.

Reviewer Checklist

  • [ ] The PR has a milestone assigned.
  • [ ] The title and description correctly express the PR's purpose.
  • [ ] Check contributor checklist is correct.
  • [ ] Check CI results: changes do not issue any warning.
  • [ ] Check CI results: failing tests are unrelated with the changes.

JLBuenoLopez avatar Feb 09 '24 09:02 JLBuenoLopez

@richiprosima please test this

JLBuenoLopez avatar Feb 15 '24 07:02 JLBuenoLopez

@richiprosima please test this

JLBuenoLopez avatar Feb 15 '24 11:02 JLBuenoLopez

@richiprosima please test this

JLBuenoLopez avatar Feb 15 '24 11:02 JLBuenoLopez

@richiprosima please test this

JLBuenoLopez avatar Feb 15 '24 15:02 JLBuenoLopez

@richiprosima please test this

JLBuenoLopez avatar Feb 16 '24 10:02 JLBuenoLopez

@richiprosima please test this

JLBuenoLopez avatar Feb 20 '24 08:02 JLBuenoLopez

Manual CI:

  • Ubuntu: failures are unrelated or known to be flaky.
  • Windows: DDSSQLFilter tests are failing in the SetUp step while registering the TypeObject. It seems that Windows is running out of stack memory.
  • MacOS: failures are unrelated or known to be flaky.

JLBuenoLopez avatar Mar 26 '24 10:03 JLBuenoLopez