Fast-DDS icon indicating copy to clipboard operation
Fast-DDS copied to clipboard

<userId> xml field for EDP is not a uint16_t [14633]

Open cinife opened this issue 2 years ago • 1 comments

Is there an already existing issue for this?

  • [X] I have searched the existing issues

Expected behavior

The range of values for the <userId> field should be in the range of uint16_t type

Current behavior

The maximum <userId> value is 255. This is a BIG limitation for some systems using Static Discovery Profiles in XML.

Steps to reproduce

In an application using static discovery profiles in XML, change any <userId> value and its correspondant data_writer <userDefinedID> for a number greather than 255

Fast DDS version/commit

Tested with FastDDS 2.4.0, 2.5.0 and 2.6.0

Platform/Architecture

Windows 10 Visual Studio 2019

Transport layer

UDPv4

Additional context

No response

XML configuration file

<data_writer profile_name="datawriter_moveplatform_edp">
             <userDefinedID>256</userDefinedID>
</data_writer>

<staticdiscovery>
    <participant>
        <name>MovePlatformPub</name>
        <writer>
            <userId>256</userId>
            <entityID>1</entityID>           
            <topicName>/Hawk/MovePlatform</topicName>
            <topicDataType>Dauphine::MovePlatfom</topicDataType>
 			 <disablePositiveAcks>
                <enabled>true</enabled>
                <duration>
                    <sec>10</sec>
                </duration>
            </disablePositiveAcks>
        </writer>
    </participant>
</staticdiscovery>

Relevant log output

No response

Network traffic capture

No response

cinife avatar May 19 '22 09:05 cinife

Thanks for your report @cinife!

#2196 already found this issue and it has fixed it partially.

JLBuenoLopez avatar May 19 '22 12:05 JLBuenoLopez

According to our CONTRIBUTING.md guidelines, I am closing this issue due to inactivity. Please, feel free to reopen it if necessary.

Mario-DL avatar Mar 24 '23 08:03 Mario-DL