Fast-DDS icon indicating copy to clipboard operation
Fast-DDS copied to clipboard

Published 20 hours ago • verified publisher icon eProsima

Allow setting complex value of non-container type

Open YangboLong opened this issue 3 years ago • 5 comments

Signed-off-by: Yangbo Long [email protected]

YangboLong avatar Apr 09 '21 14:04 YangboLong

Would you mind adding a regression test on test/unittest/xtypes/XTypesTests.cpp ?

I've added some test cases. Would you please review again? @MiguelCompany

YangboLong avatar Jun 09 '21 18:06 YangboLong

@YangboLong It seems this has conflicts. Would you mind doing a rebase?

MiguelCompany avatar Jun 10 '21 08:06 MiguelCompany

@MiguelCompany I have done it.

YangboLong avatar Jun 11 '21 15:06 YangboLong

@richiprosima Please test this

MiguelCompany avatar Jun 14 '21 05:06 MiguelCompany

@MiguelCompany I fixed the warnings on Windows last time. The Mac failure might be related to deallocation of DynamicData?

YangboLong avatar Jun 22 '21 04:06 YangboLong

Thanks @YangboLong for your contribution and sorry for the late reply. I am going to proceed and close this PR because right now, efforts to improve support for XTYPES v1.3 are being made (#3392) which supersedes this PR.

JLBuenoLopez avatar Jun 13 '23 07:06 JLBuenoLopez