Fast-DDS-docs icon indicating copy to clipboard operation
Fast-DDS-docs copied to clipboard

[21114] Check suprocess return codes on RDT generation (backport #795)

Open mergify[bot] opened this issue 1 year ago • 2 comments

Description

This PR makes the RDT generation to fail if either of the doxygen or swig commands fails. Not checking them was causing the documentation to build with API reference errors.

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Related implementation PR:

  • eProsima/Fast-DDS#4896

NOTE: As RTD build is not ready to take the appropriate Fast DDS branch and will choose master, the build will failed until eProsima/Fast-DDS#4896 is merged. I've verified on a Ubuntu 20.04 docker that the doxygen is generated without errors with that Fast DDS PR.

Contributor Checklist

  • [x] Commit messages follow the project guidelines.
  • N/A: Code snippets related to the added documentation have been provided.
  • [x] Documentation tests pass locally.
  • [x] Applicable backports have been included in the description.

Reviewer Checklist

  • [x] The PR has a milestone assigned.
  • [x] The title and description correctly express the PR's purpose.
  • [x] Check contributor checklist is correct.
  • [x] CI passes without warnings or errors.

This is an automatic backport of pull request #795 done by [Mergify](https://mergify.com).

mergify[bot] avatar Jun 05 '24 11:06 mergify[bot]

@richiprosima please test docs

Mario-DL avatar Jun 27 '24 05:06 Mario-DL

This shall include changes similar to those introduced in:

  • #796

EduPonz avatar Jul 03 '24 09:07 EduPonz

Closing because the changes mentioned here have been included in PR #1010

juanjo4936 avatar Jan 07 '25 11:01 juanjo4936