skin icon indicating copy to clipboard operation
skin copied to clipboard

feat: updated tertiary button styles

Open LuLaValva opened this issue 2 years ago • 1 comments

Fixes #1754

  • [x] This PR contains CSS changes
  • [ ] This PR does not contain CSS changes

Description

  • Updated tertiary button styles to match the design system

Screenshots

Before:

image

After:

image

Checklist

  • [x] I verify the build is in a non-broken state
  • [x] I verify all changes are within scope of the linked issue
  • [x] I regenerated all CSS files under dist folder
  • [x] I tested the UI in all supported browsers
  • [x] I tested the UI in dark mode and RTL mode
  • [ ] I added/updated/removed Storybook coverage as appropriate

LuLaValva avatar Aug 02 '22 19:08 LuLaValva

@LuLaValva , the target branch should be changed to 14.2.0.

ArtBlue avatar Aug 09 '22 15:08 ArtBlue

I updated the border to match Figma. Destructive border on Figma (#d2d2d2) is between color-neutral-1 (#f7f7f7) and color-neutral-2 (#e5e5e5) so I opted instead to set it to color-stroke-subtle which is the same as color-neutral-2. If specificity is important I can:

  1. Hardcode to match design
  2. Add some transparency to destructive tertiary buttons so they match design on a white background
  3. Add some kind of color-neutral-1-2 variable to evo-core

Let me know what you all think.

LuLaValva avatar Aug 17 '22 01:08 LuLaValva

Looking at this, I don't see the d5d5d5. The stroke subtle light is correct (there they have it as border/subtle/light) Screen Shot 2022-08-17 at 8 17 00 AM

agliga avatar Aug 17 '22 15:08 agliga

Ok, it should be complete now. My mistake on the button border colors, I have learned to use the internal Figma inspector instead of external tools. Either way, the color I chose is correct.

LuLaValva avatar Aug 17 '22 16:08 LuLaValva