skin icon indicating copy to clipboard operation
skin copied to clipboard

feat: updated filter button select state

Open LuLaValva opened this issue 2 years ago • 2 comments

Fixes #1737

  • [x] This PR contains CSS changes
  • [ ] This PR does not contain CSS changes

Description

Updated selected state to reflect changes in the design system

Notes

  • My Gemfile.lock updated automatically so I kept it in this PR, but it may not belong here. I will remove it if necessary.
  • I am not totally happy with my solution for reducing padding as I added borders, let me know if you are aware of a cleaner method.

Screenshots

Before:

image image ### After: image image

Checklist

  • [x] I verify the build is in a non-broken state
  • [x] I verify all changes are within scope of the linked issue
  • [x] I regenerated all CSS files under dist folder
  • [x] I tested the UI in all supported browsers
  • [x] I tested the UI in dark mode and RTL mode
  • [ ] I added/updated/removed Storybook coverage as appropriate

LuLaValva avatar Aug 01 '22 21:08 LuLaValva

Should be fixed now, thanks @ArtBlue

LuLaValva avatar Aug 04 '22 19:08 LuLaValva

Update: This is currently blocked due to an inconsistency in design for dark mode. The dark mode page color is black (#000000) in Figma and in the screenshot in the comment above but it is dark gray (#191919) in the attached issue (#1737).

LuLaValva avatar Aug 11 '22 19:08 LuLaValva