NuRaft
NuRaft copied to clipboard
eBay
Support build with Bazel
Support build and run tests through Bazel so developers from Bazel community can reuse scripts, as is discussed in Issue 284
As I mentioned above, please remove cert/key files and make them auto-generated.
@greensky00 Got a few busy days and I would fix issues raised in the next commit.
"This PR almost look good to me. But one concern is: do we have a better way to unify the cmake and bazel? otherwise they are hard to maintain." It is true that Bazel may use rules_foreign_cc to compile directly. But doing so would undermine dependency management, rendering automatic dependency version resolution infeasible.
As a matter of fact, glob is used while defining nuraft artifact. It would be a rare case when there is a need to modify bazel script in the future.
@greensky00 If there is no more update, how about merging this PR and then we're refining it in the next PR?
I'm looking forward this feature to integrate it to our repo in bazel building toolchain.
Hi @jovany-wang I'm ok with partial merging, but before that, the cert files must be removed as it is monitored by the security team. Since those dummy cert files are used for SSL testing only, this PR may need to exclude building unit tests, but still compiling the library itself should be fine.