speedtest icon indicating copy to clipboard operation
speedtest copied to clipboard

Add a option to disable fetch ipinfo

Open askfor opened this issue 3 years ago • 7 comments

Hi, it seems we can't disable fetch ipinfo yet. It'd be nice to add an option to disable ipinfo function, so Speedtest can run on the intranet.

askfor avatar Dec 17 '20 09:12 askfor

Hello @askfor

I can handle offline or intranet situations fairly easily, by making ipInfo fail silently, returning the sole IP, without further information. If I do so, no need to disable ipInfo check.

Would that be sufficient for you case scenario?

e7d avatar Jan 23 '21 09:01 e7d

Hi, Yes, it's sufficient for my case, and this solutions is also simpler for users. Thanks.

askfor avatar Jan 23 '21 10:01 askfor

Okay then. I have it ready on the development branch. I will probably release a 0.5.3 soon enough, including the fix.

e7d avatar Jan 23 '21 12:01 e7d

Hi, it seems the speed test will only start after the IP resolution failed? How about making IP resolution asynchronously? But anyway it works on the intranet, Thanks.

askfor avatar Feb 09 '21 05:02 askfor

Hi Michael - firstly, thanks for a great project! I have the same issue as the OP - our intranet users won't have resolvable IPs Either disabling the ipinfo or making it run async would be fantastic Do you think you can push this up to the master branch/updated docker? I would love to test this out further

mickeylieu avatar Feb 15 '21 17:02 mickeylieu

Either disabling the ipinfo or making it run async would be fantastic Do you think you can push this up to the master branch/updated docker? I would love to test this out further

The latest docker image works on the intranet already.

askfor avatar Feb 16 '21 07:02 askfor

Thanks! We loaded the docker image but each test initiation takes about 2 mins for the ipinfo to timeout before the speedtest begins running - is there a switch or something we can do to stop the lookup? Otherwise the test works perfectly! :)

mickeylieu avatar Feb 16 '21 11:02 mickeylieu