e3dio
e3dio
Guys... this is terrible. Only printing 100 characters of a string that you explicitly told the console to log is incomprehensibly bad. I have a question.. does ANYONE here actually...
Here are screenshots of 1,000 and 10,000 characters. 1,000 takes up only a couple lines of terminal. 10,000 takes up a little bit more. At the very least I'd be...
I have a lot of different code running, 10 terminals on a 4k monitor, all of them logging various things, very often objects with strings, and EVERY SINGLE TIME I...
@iuioiua I tried setting the headers to mutable and appending to them after generating upgrade response but it doesn't work, with new `Deno.serve` they are doing websocket upgrade and sending...
@iuioiua Nope you did not read my previous post, in the new `Deno.serve` the upgrade and response takes place during the `Deno.upgradeWebSocket` call and not after. The returned response object...
Deno.serve request has special function for upgrading websocket here https://github.com/denoland/deno/blob/main/ext/http/01_http.js#L466C13-L466C26 In that function the upgrade and response happens here https://github.com/denoland/deno/blob/main/ext/http/00_serve.js#L195C25-L195C55 with the headers that were set here https://github.com/denoland/deno/blob/main/ext/http/01_http.js#L439C5-L439C15 Then it...
I'm not saying this is the way it should be, just the way it is currently, and I want to change the least amount of code to get this feature...
So you think do this: ```js const headers = new Headers({ 'Set-Cookie': 'Hello=123' }); const { socket, response } = Deno.upgradeWebSocket(request, { headers }); ``` But in the docs say:...
You could do a deny list of the 4 headers that Deno already covers for the response: `upgrade`, `connection`, `sec-websocket-accept` and `sec-websocket-protocol` That would help developers who might not understand...
Ok I updated PR, added test for Deno.serve, includes deny header list. I don't like deny header list because it is unnecessary overhead converting strings to lowercase and comparing headers...