pandapower
pandapower copied to clipboard
fix unbalanced powerflow with out of service ext grids
Solves a mismatch of arrays during zero impedance addition of ext grids if at least one ext grid is out of service
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.66%. Comparing base (
f2794c6
) to head (4613282
). Report is 106 commits behind head on develop.
:exclamation: Current head 4613282 differs from pull request most recent head 14c156e
Please upload reports for the commit 14c156e to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## develop #2227 +/- ##
============================================
+ Coverage 62.30% 79.66% +17.36%
============================================
Files 255 255
Lines 28062 27840 -222
============================================
+ Hits 17483 22178 +4695
+ Misses 10579 5662 -4917
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This one was merged: fix unbalanced powerflow with out ouf service ext grids #2184
Is this PR still relevant?
@jkupka @dlohmeier still relevant?
yes, it's still relevant as it solves a different issue than #2184
@jkupka please address the change request
for some reason, I cannot push to this branch with opened PR or open a PR to that branch, but I can confirm that the conflicts are regarding the changelog only.
The merge conflict was resolved. Failing tests seem to have nothing to do with the changes in this pull request
The merge conflict was resolved. Failing tests seem to have nothing to do with the changes in this pull request
For some reason, I still cannot merge. Maybe git rebase
is needed or something else. I don't know. Alternatively, I open another PR with the same fix.
@rbolgaryn can you approve? Seems like it is not possible to merge without your approval.