emba icon indicating copy to clipboard operation
emba copied to clipboard

Excessive permissions

Open nuschpl opened this issue 2 years ago • 12 comments

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. EMBA installation (dev-mode/default mode)
  2. default-mde
  3. Use the firmware available here: N/A
  4. Start EMBA with the following parameters: ./emba.sh -f anyfirmware.bin
  5. See error With docker enabled this script needs root privileges

Expected behavior There is no reason software of this kind should need root privileges every time. Especially when most of work is done within containers

nuschpl avatar Sep 01 '22 07:09 nuschpl

Currently EMBA needs root privs for multiple extraction modules, as well as for the chroot environment from the user-mode emulator.

m-1-k-3 avatar Sep 01 '22 08:09 m-1-k-3

What kind of extraction needs root ? If you need chroot there is no problem with launching chroot command itself with sudo, instead of running full framework full of uncertain tools as root. Why won't you preciselty state those issues so other could contribute to those subissues ? You are building security tool and ignoring basic security principles - AFAIR emulator is optional and the message says it's docker related . What is purpose for running containerized environmen at all if we don't care about security

nuschpl avatar Sep 01 '22 13:09 nuschpl

Why won't you preciselty state those issues so other could contribute to those subissues ?

Keep calm guy ... if you ask you get the info.

You are building security tool and ignoring basic security principles

On the other side you do not need to use it at all.

For all that are interested the following modules currently need root privs:

  • P10
  • P14
  • ~~P18~~ Module removed
  • P19
  • P20
  • S115
  • L10

Probably other modules also need root privs. I need to check this in detail.

m-1-k-3 avatar Sep 01 '22 14:09 m-1-k-3

This issue is stale because it has been open for 28 days with no activity.

github-actions[bot] avatar Sep 30 '22 04:09 github-actions[bot]

This issue is stale because it has been open for 28 days with no activity.

github-actions[bot] avatar Nov 18 '22 02:11 github-actions[bot]

This issue is stale because it has been open for 28 days with no activity.

github-actions[bot] avatar Jul 24 '23 01:07 github-actions[bot]

This issue is stale because it has been open for 28 days with no activity.

github-actions[bot] avatar Oct 16 '23 01:10 github-actions[bot]

for sure its recommended to run nested vm's i run the root commands in the docker image on the bottom of those nested vm's

farmmanic avatar Mar 16 '24 04:03 farmmanic

This issue is stale because it has been open for 28 days with no activity.

github-actions[bot] avatar Apr 14 '24 01:04 github-actions[bot]

How the #wontfix and #Research tags come all together, does it mean there is an intent to change current behaviour (ongoing work or PR accept) or not ?

nuschpl avatar Apr 14 '24 14:04 nuschpl

#research -> further research work needed to identify all the affected areas and start repairing them or find some solution #wontfix -> we currently do not have the resources to fix this within the core team

If you would like to start digging into this issue you are welcome. We can use this issue for further discussions, as well as a dedicated disussion in the gh discussion area.

m-1-k-3 avatar Apr 14 '24 15:04 m-1-k-3

This issue is stale because it has been open for 28 days with no activity.

github-actions[bot] avatar May 14 '24 01:05 github-actions[bot]