Reveal.js-TOC-Progress icon indicating copy to clipboard operation
Reveal.js-TOC-Progress copied to clipboard

compatibility with reveal.js 4.X

Open Thus0 opened this issue 3 years ago • 5 comments

I just discovered this wonderfull plugin. I'm trying to use it with reveal-md to create slides from markdown notes but I cannot make it work... I have an error because I think the 'id' parameter is missing : cf. creating plugin

From the documentation :

// toaster.js
export default () => {
  id: 'toaster',
  init: ( deck ) => {
    deck.addKeyBinding( { keyCode: 84, key: 'T' }, () => {
      deck.shuffle();
      console.log('🍻');
    } );
  }
}

Is the plugin compatible with Revealjs 4.x ?

Otherwise, I've tried to write a POC of the plugin with Reveal.js 4.x format but I'm starting from scratch (I've never wrote a plugin). I can load the patched plugin with reveal-md :)

Thus0 avatar Feb 25 '22 10:02 Thus0

Actually, I do not know... I developed it some years ago and I cannot even remember which version I did it for, so I do not know if it is a compatibility problem with this version, but it could be. And I cannot currently devote time to it, sorry...

e-gor avatar Feb 25 '22 10:02 e-gor

OK no problem : i will fork your code and will try to merge later to your branch :)

Thanks again !!

For those who want to test this experimental port to Revealjs 4.x : https://github.com/Thus0/Reveal.js-TOC-Progress/blob/Thus-fork-revealjs-4x/plugin/toc-progress/toc-progress4x.js

Thus0 avatar Feb 25 '22 10:02 Thus0

OK, thanks!

e-gor avatar Feb 25 '22 15:02 e-gor

I tested both and the actual version is fine with reveal.js 4.5.0

mathben avatar Apr 26 '23 23:04 mathben

Finally, a couple of minor bug occur. Example, the no-toc-progress change to another section when go back. By default, toc_progress.create(); doesn't work, need to press q each time when reload. Cannot use mouse to change section, (I use keyboard arrows)

mathben avatar Apr 27 '23 01:04 mathben