terraform-provider-netbox icon indicating copy to clipboard operation
terraform-provider-netbox copied to clipboard

[feature/netbox_device_custom_fields] added support custom_fields for…

Open doncu opened this issue 2 years ago • 7 comments

added support custom_fields for resource netbox_device, updated documentation. increased go version - up to 1.19 in go.mod

doncu avatar Sep 20 '22 12:09 doncu

@fbreckle hi! can you run the pipe? locally all tests worked correctly

doncu avatar Sep 27 '22 19:09 doncu

@fbreckle hi! looks like it's time to merge can you do it?

doncu avatar Sep 28 '22 11:09 doncu

github says: "This branch cannot be rebased due to conflicts"

fbreckle avatar Sep 28 '22 15:09 fbreckle

github says: "This branch cannot be rebased due to conflicts"

@fbreckle Upss, Done!

doncu avatar Sep 28 '22 20:09 doncu

I get the following when I run the tests on my machine, but in CI this seems to work. Hmmm...

`data_source_netbox_virtual_machines_test.go:15: Step 1/5 error: After applying this test step, the plan was not empty. stdout:

    Terraform used the selected providers to generate the following execution
    plan. Resource actions are indicated with the following symbols:
      ~ update in-place
    
    Terraform will perform the following actions:
    
      # netbox_device.test will be updated in-place
      ~ resource "netbox_device" "test" {
          ~ custom_fields  = {
              - "custom_field" = "" -> null
            }
            id             = "9"
            name           = "test-vm_ds_basic-37ix6o6u6c"
            # (7 unchanged attributes hidden)
        }
    
    Plan: 0 to add, 1 to change, 0 to destroy.`

fbreckle avatar Oct 05 '22 08:10 fbreckle

well, locally I don't have any problems and functional works is correct , i'm already use in my production env

doncu avatar Oct 06 '22 13:10 doncu

Hi there, any news from this PR?

nicoovh avatar Oct 24 '22 09:10 nicoovh