terraform-provider-netbox icon indicating copy to clipboard operation
terraform-provider-netbox copied to clipboard

✨ Add request timeout for http client via NETBOX_REQUEST_TIMEOUT

Open twink0r opened this issue 2 years ago • 1 comments

twink0r avatar Aug 25 '22 11:08 twink0r

Hi!

Thank you for this pr! I wonder if we lose some value with the "if 0 is given, use 10" logic, because the docs of the http package say // A Timeout of zero means no timeout., which might be a behavior that is useful for some people.

Can we use the default value field of EnvDefaultFunc instead? Thoughts?

PS: Also, can you please update the docs with go generate :D

fbreckle avatar Aug 30 '22 19:08 fbreckle

Hi @fbreckle,

you are totally right! Updated the PR.

twink0r avatar Sep 02 '22 07:09 twink0r