ocdownloader icon indicating copy to clipboard operation
ocdownloader copied to clipboard

support for nextcloud 24

Open JasonPoon-cn opened this issue 2 years ago • 14 comments

/appinfo/app.php is deprecated, use \OCP\AppFramework\Bootstrap\IBootstrap on the application class instead.

closes #245

fixes #248

JasonPoon-cn avatar May 11 '22 02:05 JasonPoon-cn

Thanks for the PR @JasonPoon-cn .

Going to test the PR as soon as possible.

weeman1337 avatar May 11 '22 17:05 weeman1337

@JasonPoon-cn Seems like this PR would break support for Nextcloud older than 24, could you revive the support for older versions as well?

ghost avatar May 28 '22 11:05 ghost

And, nextcloud 24 have too many bugs so I wouldn't recommend using it, 23 is stable and robust enough

ghost avatar May 28 '22 11:05 ghost

@ayanamidev I tried do it,but it‘s break, i'm an amateur, It's difficult for me.

JasonPoon-cn avatar May 30 '22 00:05 JasonPoon-cn

I have checked this PR on version 24.0.1 and it works like a charm.

bekon16 avatar Jun 01 '22 10:06 bekon16

Hi, using NC 24.0.1.1, ocDownloader throws an exception:

OC\\Files\\Utils\\Scanner::__construct(): Argument #4 ($logger) must be of type Psr\\Log\\LoggerInterface, OC\\Log given, called in /apps/ocdownloader/controller/index.php on line 249

Fixed this error by replacing in /apps/ocdownloader/controller/index.php line 249: $scanner = new \OC\Files\Utils\Scanner($user, \OC::$server->getDatabaseConnection(), \OC::$server->query(IEventDispatcher::class), \OC::$server->getLogger()); with: $scanner = new \OC\Files\Utils\Scanner($user, \OC::$server->getDatabaseConnection(), \OC::$server->query(IEventDispatcher::class), \OC::$server->get(LoggerInterface::class));

And add line 24: use Psr\Log\LoggerInterface;

nlublovary avatar Jun 20 '22 03:06 nlublovary

Any news?

MadMakz avatar Jul 19 '22 17:07 MadMakz

Tested on NC24, works.

Thanks @JasonPoon-cn for your contribution.

@e-alfred can you merge this and publish a release?

weeman1337 avatar Aug 06 '22 09:08 weeman1337

@e-alfred did you had a chance to look at this PR?

weeman1337 avatar Sep 04 '22 14:09 weeman1337

last activity Dec. 27 2021 from @e-alfred :\ hmmm... covit ?

blackcrack avatar Sep 04 '22 22:09 blackcrack

Good afternoon, you did not make this fix in release 1.8.1, the current version is not compatible with nс 24

0rb1ta avatar Sep 09 '22 09:09 0rb1ta

Hello. And fix by nlublovary is not working in 24.0.4. At least for me.

BUG-reporter avatar Sep 09 '22 19:09 BUG-reporter

Hello. And fix by nlublovary is not working in 24.0.4. At least for me.

For me - working, 249 line - $scanner = new \OC\Files\Utils\Scanner($user, \OC::$server->getDatabaseConnection(), \OC::$server->query(IEventDispatcher::class), \OC::$server->get(LoggerInterface::class)); 24 line - use Psr\Log\LoggerInterface;

0rb1ta avatar Sep 09 '22 20:09 0rb1ta

Hello. And fix by nlublovary is not working in 24.0.4. At least for me.

For me - working, 249 line - $scanner = new \OC\Files\Utils\Scanner($user, \OC::$server->getDatabaseConnection(), \OC::$server->query(IEventDispatcher::class), \OC::$server->get(LoggerInterface::class)); 24 line - use Psr\Log\LoggerInterface;

Oh, I forgot about line 24. It is working for me again in 24.0.5. Thank you.

BUG-reporter avatar Sep 09 '22 20:09 BUG-reporter

Thank you for your PR, I merged it and make a new release as soon as possible.

e-alfred avatar Nov 07 '22 12:11 e-alfred