ocdownloader
ocdownloader copied to clipboard
support for nextcloud 24
/appinfo/app.php is deprecated, use \OCP\AppFramework\Bootstrap\IBootstrap on the application class instead.
closes #245
fixes #248
Thanks for the PR @JasonPoon-cn .
Going to test the PR as soon as possible.
@JasonPoon-cn Seems like this PR would break support for Nextcloud older than 24, could you revive the support for older versions as well?
And, nextcloud 24 have too many bugs so I wouldn't recommend using it, 23 is stable and robust enough
@ayanamidev I tried do it,but it‘s break, i'm an amateur, It's difficult for me.
I have checked this PR on version 24.0.1 and it works like a charm.
Hi, using NC 24.0.1.1, ocDownloader throws an exception:
OC\\Files\\Utils\\Scanner::__construct(): Argument #4 ($logger) must be of type Psr\\Log\\LoggerInterface, OC\\Log given, called in /apps/ocdownloader/controller/index.php on line 249
Fixed this error by replacing in /apps/ocdownloader/controller/index.php line 249:
$scanner = new \OC\Files\Utils\Scanner($user, \OC::$server->getDatabaseConnection(), \OC::$server->query(IEventDispatcher::class), \OC::$server->getLogger());
with:
$scanner = new \OC\Files\Utils\Scanner($user, \OC::$server->getDatabaseConnection(), \OC::$server->query(IEventDispatcher::class), \OC::$server->get(LoggerInterface::class));
And add line 24:
use Psr\Log\LoggerInterface;
Any news?
Tested on NC24, works.
Thanks @JasonPoon-cn for your contribution.
@e-alfred can you merge this and publish a release?
@e-alfred did you had a chance to look at this PR?
last activity Dec. 27 2021 from @e-alfred :\ hmmm... covit ?
Good afternoon, you did not make this fix in release 1.8.1, the current version is not compatible with nс 24
Hello. And fix by nlublovary is not working in 24.0.4. At least for me.
Hello. And fix by nlublovary is not working in 24.0.4. At least for me.
For me - working, 249 line - $scanner = new \OC\Files\Utils\Scanner($user, \OC::$server->getDatabaseConnection(), \OC::$server->query(IEventDispatcher::class), \OC::$server->get(LoggerInterface::class)); 24 line - use Psr\Log\LoggerInterface;
Hello. And fix by nlublovary is not working in 24.0.4. At least for me.
For me - working, 249 line - $scanner = new \OC\Files\Utils\Scanner($user, \OC::$server->getDatabaseConnection(), \OC::$server->query(IEventDispatcher::class), \OC::$server->get(LoggerInterface::class)); 24 line - use Psr\Log\LoggerInterface;
Oh, I forgot about line 24. It is working for me again in 24.0.5. Thank you.
Thank you for your PR, I merged it and make a new release as soon as possible.