epubreader icon indicating copy to clipboard operation
epubreader copied to clipboard

Add support to NC 23

Open lanawwas opened this issue 3 years ago • 9 comments
trafficstars

This app cannot be installed because the following dependencies are not fulfilled: Server version 21 or lower is required.

lanawwas avatar Dec 03 '21 16:12 lanawwas

As an administrator of a comic book archive the support on new versions of NC is very important. I second the request.

BodoWitcha avatar Dec 06 '21 06:12 BodoWitcha

it worked for me today

manuelkamp avatar Jan 01 '22 21:01 manuelkamp

@manualkamp - Thanks. It worked for me too.

BodoWitcha avatar Jan 01 '22 22:01 BodoWitcha

Guys, does it save progress for you? I tried NC 22 snap package, as well as 23 run from docker and neither of them saves read position, much to my annoyance

ickam avatar Feb 27 '22 14:02 ickam

My PR #42 should fix this (I hope !)

sysadminstory avatar Mar 22 '22 11:03 sysadminstory

My PR #42 should fix this (I hope !)

And it seems it did! :) Thank you for your wonderful contribution to the splendid app. It has minor quirks, but the really worst for all on Nextcloud 24 is that the reader is not compatible and installable from the app repository ;( (Issue is here). Do you perhaps know if this is just a simple meta-tag issue (23->24), or if it might break some of the nice fixes you have done?

Mangleuz avatar Jun 25 '22 15:06 Mangleuz

#42 didn't seem to fix the sync for me.

scurrvy2020 avatar Jul 12 '22 01:07 scurrvy2020

My PR #42 should fix this (I hope !)

And it seems it did! :) Thank you for your wonderful contribution to the splendid app. It has minor quirks, but the really worst for all on Nextcloud 24 is that the reader is not compatible and installable from the app repository ;( (Issue is here). Do you perhaps know if this is just a simple meta-tag issue (23->24), or if it might break some of the nice fixes you have done?

I'm totally not a Nextcloud App developer, so I can not be sure if it should work (I'm still using Nextcloud 22). I tried to replace the deprecated feature I saw during the fix, so Nextcloud 24 could work. You might test editing the info.xml file to change the supported version.

sysadminstory avatar Jul 17 '22 12:07 sysadminstory

#42 didn't seem to fix the sync for me.

Do you have any request to a URL ending with "cursor" while changing pages ? What is HTTP return code for those requests ?

sysadminstory avatar Jul 17 '22 12:07 sysadminstory