dzmitry-lahoda

Results 432 comments of dzmitry-lahoda

i needed to pass clone of param array if call was by ref and the index as int in pull #90. if we could limit param to 256 items i...

https://github.com/dadhi/FastExpressionCompiler/blob/707a8cfe6c12d6cc9504e643d534522d4104c47f/src/FastExpressionCompiler/FastExpressionCompiler.cs#L2303 Bug? (only _S call, but no without suffix) https://github.com/dadhi/FastExpressionCompiler/blob/707a8cfe6c12d6cc9504e643d534522d4104c47f/src/FastExpressionCompiler/FastExpressionCompiler.cs#L1737 Not bug, but more check and code. And what if for loops by `short` are faster? I.e. it is by...

`Stloc` - somewhere used short limit, somewhere byte. Possible bugs. I.e. I guess FEC will not compile anything with more that 255 params. And where long form used it used...

Slow expression compiler:) ``` var c = short.MaxValue-(short.MaxValue/4); var variables = new ParameterExpression[c]; var assignments = new BinaryExpression[c]; for (int i = 0; i < c; i++) { variables[i] =...

SOE from FEC, but not from LINQ (linq is fine) ``` var c = short.MaxValue/8; var exprected = 0; for (int i = 0; i < c; i++) { exprected...

Need to wait for Travis will update ``` CSC : error CS1617: Invalid option '7.3' for /langversion; must be ISO-1, ISO-2, Default, Latest or a valid version in range 1...

May do GC free copy free programming with https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/in-parameter-modifier and other ref improvements

That look promising https://github.com/dotnet/corefx/blob/master/src/System.Linq.Expressions/tests/Lambda/LambdaTests.cs#L84

Will port deep trees and wide parameters test by manual copy with retain original naming so it would be possible to maintain stuff.

Is it still an issue I may look at?