dzhuang
dzhuang
> Here's a pretty important question that occurred to me: Can you find/add a link in source to nbconvert's policy on whether it's designed to be safe with untrusted input?...
@inducer https://jupyter-notebook.readthedocs.io/en/stable/security.html#security-in-notebook-documents That's the documentation about the security of notebook itself. I didn't found the docs for nbconvert.
There's a [sanitize preprocessor](https://github.com/jupyter/nbconvert/blob/910c23f3225c2ced6d291424ea241d19d1077d05/nbconvert/preprocessors/sanitize.py), we need to make sure the preprocessor is included when we do the convert.
Thanks. I guess the issue you mentioned is the removal of `glyphicons` in Bootstrap 5, I'll try to work on that in a few days.
This PR is closed in favor of #949.
A PR is welcome, and I agree warnings that the migation for instances and clearing page caches should be done between semester are needed.
I'm ok with it. My fork is more than 100 commit behind yours, and I'll find time to catch up.
@inducer Can you review this? Thanks. The two TODOs need your verfication, thanks.
@inducer Can you look at this PR and make sure the migration is correct? I wish to integrate this into my instance soon, new semester is coming. Thanks!
For record: This might result in inconsistency when grade changes are ordered improperly. > grades accumulation strategy: `use_latest` > A: grade time 2015 > B: grade time 2016, flow completed...