potential-changes-for-github icon indicating copy to clipboard operation
potential-changes-for-github copied to clipboard

Closing the dropdown when clicking outside of it

Open dzhavat opened this issue 6 years ago • 2 comments

Right now, the only way to close the dropdown list is by clicking again on the button.

demo

It'd be nice if the dropdown could close when clicking outside of it. That'd also make it behave similarly to all other dropdowns on GitHub.

dzhavat avatar Dec 24 '18 10:12 dzhavat

This is best implemented by copying the native <details> implementation that other GitHub buttons have. You can copy the whole Filter dropdown and also fix this other issue in one go: https://github.com/dzhavat/potential-changes-for-github/issues/8

fregante avatar Dec 29 '18 10:12 fregante

Nice! Will give it a try 👍

dzhavat avatar Dec 29 '18 21:12 dzhavat