DZNPhotoPickerController icon indicating copy to clipboard operation
DZNPhotoPickerController copied to clipboard

Google Images integration. Fixes #111

Open ebalassanian opened this issue 8 years ago • 5 comments

These changes address issues with the google service. Google only allows 10 photos per search. This code will recursively fetch more results until the total number needed to fulfill the search page are returned. Google also returns an error after 100 results are fetched so that is the hard limit on the number of images per query. There are also a few other fixes for UI includes the searchbar when there is only one title. This code could be cleaned up a bit by having a constant that defines the maximum number of results for a given service. Currently this is hardcoded in the params for the service. Theoretically the code should work for any “underperforming” service.

ebalassanian avatar May 03 '16 18:05 ebalassanian

Thanks for this. Will review soon-ish.

dzenbot avatar May 03 '16 19:05 dzenbot

I had a merge issue with DZNPhotoPickerController.m. I'll submit the fix momentarily.

ebalassanian avatar May 03 '16 19:05 ebalassanian

Yes, that was my merge issue. Apologies for not catching it the first time... so if you're ok with the rest of the changes, you have the full edits now.

ebalassanian avatar May 04 '16 00:05 ebalassanian

Hi, Thank you. My team is shipping a user story using the Google image search. I'd like to request a merge on the fix to help ship the feature.

Thank you, James

jocean4 avatar Mar 30 '17 19:03 jocean4

Hi! Any plans for merging this pull request?

xradeon avatar Jul 12 '17 17:07 xradeon