DZNEmptyDataSet icon indicating copy to clipboard operation
DZNEmptyDataSet copied to clipboard
verified publisher icon dzenbot

Revert #259

Open colinhumber opened this issue 8 years ago • 2 comments

If a custom view has a UIControl subclass, the -gestureRecognizer:shouldReceiveTouch: call is necessary to allow touches to pass through to the control immediately. Without this call, touches are delayed, and the touch up action on the control doesn't fire unless the control is tapped for an extended period of time.

The call here is checking to see if the tap gesture on the DZNEmptyDataSetView should receive touches. If the tapped view is a UIControl, the gesture recognizer shouldn't receive any touches and should instead pass them along to the UIControl for processing.

colinhumber avatar Jul 01 '17 04:07 colinhumber

I know this is old, but didn't we intentionally revert this time ago, because of https://github.com/dzenbot/DZNEmptyDataSet/commit/ce506bd1d11571d260a426e0f657a6db7d95fe97 ? I'm so confused with these changes 🤦‍♂️

dzenbot avatar Jan 24 '18 19:01 dzenbot

That code was added in ce506bd1d11571d260a426e0f657a6db7d95fe97 but was then removed in 3d2d8b54b5c2914bfba9a29d21046b6fbfd8c15f for some reason, which broke taps being allowed on UIControls. This PR reimplements that behaviour.

There's no additional info on the commit that removed that behaviour, other than it was "unnecessary code".

colinhumber avatar Jan 24 '18 20:01 colinhumber