Dženan Zukić

One test still fails to compile on VS2019: ```log Build started... 1>------ Build started: Project: aom_config_h_tmpl, Configuration: RelWithDebInfo x64 ------ 2>------ Build started: Project: aom_config_asm_tmpl, Configuration: RelWithDebInfo x64 ------ 3>------...

Bumping CI Ubuntu to 22.04 leads to a [strange new error](https://open.cdash.org/build/8244015/configure): ```log ... Loading /home/runner/work/ITKIOOMEZarrNGFF/build/_deps/riegeli-src/riegeli/varint/BUILD -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY --...

By always building tensorstore as static library, I am now down to [build warnings](https://open.cdash.org/viewBuildError.php?type=1&buildid=8248121) from AOM, of the style: `_deps/aom-src/aom_dsp/grain_table.c:108:5: warning: ignoring return value of 'fscanf' declared with attribute 'warn_unused_result'...

> This particular warning would be fixed by updating our version of aom. This would allow me to avoid suppressing this warning, and also close this issue 😄

My [attempt to update AOM](https://github.com/dzenanz/tensorstore/commit/e9c036463743ee8ce278b9320592deb166036e75) doesn't even build locally: ```log Loading C:/Misc/tensorstore-vs19/_deps/aom-src/BUILD.bazel Traceback (most recent call last): File "C:\Misc\tensorstore\tools\cmake\bazel_to_cmake\evaluation.py", line 185, in get_optional_target_info rule_info.impl() File "C:\Misc\tensorstore\tools\cmake\bazel_to_cmake\native_rules.py", line 285, in lambda:...

Thank you @laramiel. That reduces number of [warnings](https://open.cdash.org/viewBuildError.php?type=1&buildid=8251085) from 6 to 3. It is still the same kind of warnings: `_deps/aom-src/aom_dsp/grain_table.c:145:11: warning: ignoring return value of 'fscanf' declared with attribute...

I suppressed those warnings in the Linux CI, so now Mac CI finishes. However, it has [50+ warnings](https://open.cdash.org/viewBuildError.php?type=1&buildid=8251266) of the style: `/Applications/Xcode_13.2.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: /.../ITK-build/libaom_av1.a(optical_flow.c.o) has no symbols`. I am trying...

That suppression worked, which uncovered further [22 warnings](https://open.cdash.org/viewBuildError.php?type=1&buildid=8252888) of the kind `_deps/curl-src/lib/vtls/sectransp.c:1006:6: warning: address of function 'SecCertificateCopyLongDescription' will always evaluate to 'true' [-Wpointer-bool-conversion]`. I will suppress them too.

Oh, there is also a bunch of [warnings on Windows](https://open.cdash.org/viewBuildError.php?type=1&buildid=8253023): `D:\a\ITKIOOMEZarrNGFF\build\_deps\riegeli-src\riegeli\base\assert.h(147) : warning C4722: 'riegeli::internal::UnreachableStream::~UnreachableStream': destructor never returns, potential memory leak`

I solved my noisy warnings CI problem by [suppressing them](https://github.com/dzenanz/ITKIOOMEZarrNGFF/commit/24e386b20127d88c03a16da5ded870e20e7b4b83): ```cmake set(CTEST_CUSTOM_WARNING_EXCEPTION ${CTEST_CUSTOM_WARNING_EXCEPTION} "Wunused-result" "file: .+ has no symbols" "Wpointer-bool-conversion" "note: prefix with the address-of operator to silence this warning"...