leblad icon indicating copy to clipboard operation
leblad copied to clipboard

Natural disaster list for each wilaya

Open abderrahmaneMustapha opened this issue 3 years ago • 8 comments

add a list of natural disaster for each Wilaya example :

 {
 "WilayaName": {
    "natural disaster":{
        "earthquakes" : [
             {"name": "name" , "date " :  22-3-2000, "deaths" : 1 , .more ......}
         ],
        "floods": [.......] 
      ........
}
}
}

abderrahmaneMustapha avatar Sep 29 '20 13:09 abderrahmaneMustapha

Would you add this to the original dataset or add it as a plugin?
I personally prefer having it as an external dependency, and if I want to use it I'll just install it. Internally that plugin will just merge our data array with this natural disaster by wilaya array. This idea could be the same for each additional information especially those who can be updated consistently (natural disasters, population...)

Fcmam5 avatar Sep 29 '20 14:09 Fcmam5

we can schedule a call and talk about it !

abderrahmaneMustapha avatar Oct 01 '20 12:10 abderrahmaneMustapha

As a wrap-up for our call:

  • We add an .extend functionality where we extend our library with a new plugin containing a dataset+functions

Fcmam5 avatar Oct 05 '20 15:10 Fcmam5

Yes, @Fcmam5 seems like an excellent idea. I'm really curious to see an implementation of a plugin or extension base on the dateset. and better to move this discussion to algeria api and create a proof of concept of how plugin should be implemented.If everything goes fine, we can mention the plugin in the project as a guide. what do you think ?

Redaloukil avatar Oct 13 '20 21:10 Redaloukil

hi @Redaloukil i already start the implementation of this plugin click here

abderrahmaneMustapha avatar Oct 13 '20 22:10 abderrahmaneMustapha

@Fcmam5 @Redaloukil @abderrahmaneMustapha we need to work closely with algeria-api-natural-disaster Will put a draft of the requirements and then As suggested by @Redaloukil we will do a PoC, once tested and proven to be stable, we merge.

Let's keep this thread for highlights and progress, will move the discussion to the slack workspace

ZibanPirate avatar Nov 17 '20 10:11 ZibanPirate

I'd appreciate scheduling a call to discuss this

Fcmam5 avatar Nov 17 '20 11:11 Fcmam5

@Fcmam5 sure thing, @Redaloukil it would be great if you could join an open discussion on slack

ZibanPirate avatar Nov 17 '20 11:11 ZibanPirate