Trendy icon indicating copy to clipboard operation
Trendy copied to clipboard

env requirements, numpy version test, datareader import update, readme update, license update, bollinger band func()

Open timothyyu opened this issue 7 years ago • 1 comments

Pull request proposal for dysonance/trendy:

trendy.py:

  • Incorporated "bug in gentrends #1" PR fix by fraka6 into segtrends(). https://github.com/dysonance/Trendy/issues/1
  • Moved imports to beginning of trendy.py + removed redundant imports
  • Updated pandas_datareader import from pandas.io.data
  • Added bbands function from kimtaesu fork (https://github.com/kimtaesu/Trendy/commit/29fc88a35f3a701b9e2c309957cb23bb6d1c9f78)

README.md:

  • pandas_datareader update from pandas.io.data to pandas_datareader (https://github.com/timothyyu/Trendy/commit/d5a96953c7f2859f00477f76bcb1f4ff01b8f948) LICENSE.txt:
  • Added copyright/name of original repository creator + year

NEW CHANGES:

  • Added basic unit test for Numpy version 1.12.1; masked array behavior changed after 1.12.1 numpy versions, and minitrends() will fail with an index boolean error without a rewrite taking this change of behavior into account
  • Created requirements.txt (pip) and environment.yml (anaconda/conda) for package requirements; current code for minitrends() requires numpy 1.12.1 or lower to function properly without a rewrite or reimplementation of local minima/maximia detection (for masked arrays)
  • Added GNU GPL v2.0 file modification notices

timothyyu avatar Dec 23 '18 19:12 timothyyu

incorporates https://github.com/dysonance/Trendy/issues/1 (already merged)

timothyyu avatar Dec 23 '18 19:12 timothyyu