frei0r icon indicating copy to clipboard operation
frei0r copied to clipboard
verified publisher icon dyne

fix MSVC compilation

Open eszlari opened this issue 4 years ago • 2 comments

The following filters needed to be disabled because of Variable Length Arrays (VLA), but are enabled when compiling with clang-cl:

  • curves
  • d90stairsteppingfix
  • dither

eszlari avatar Feb 20 '21 11:02 eszlari

This looks good to me, but I have not tested it myself. I trust this contributor as he is helping MLT and Shotcut convert to CMake and maintains many Flatpaks for many projects.

ddennedy avatar Feb 22 '21 06:02 ddennedy

btw: My intention is to add frei0r to https://github.com/microsoft/vcpkg.

eszlari avatar Feb 22 '21 20:02 eszlari

@eszlari can you help me understand how to best resolve this conflict? image

also, do you think that the build you are trying to enable can be in some way reproduced by GitHub actions?

jaromil avatar Nov 23 '22 15:11 jaromil

conflicts resolved, msvc build goes well

will try to include it into the upcoming release build, see #130

jaromil avatar Dec 27 '22 15:12 jaromil

:tada: This PR is included in version 1.9.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Dec 27 '22 22:12 github-actions[bot]