Zenroom icon indicating copy to clipboard operation
Zenroom copied to clipboard

GA refactoring

Open puria opened this issue 3 years ago • 7 comments

Does not make sense to wait 2h long for testing and building on each commit and install zsh more than 30 times... Let's fix this workflow ;)

  • [x] Research on the trend for organizing the github actions workflow
  • [x] Engage reusable workflows at organization level https://github.com/dyne/workflows/
  • [ ] Also make reusable steps as per this
  • [x] Make a fast execution testing by providing PR labels see
  • [ ] Then we deliver a light and nice Developer eXperince ;)

puria avatar Sep 16 '22 07:09 puria

A first idea to speed up the workflows may be to use caching.

matteo-cristino avatar Sep 16 '22 09:09 matteo-cristino

Bravo

puria avatar Sep 16 '22 10:09 puria

Build wheels on Ubutnu and Macos inside Build and upload nightly to PyPI can be made less time consuming using parallel computation by expand the matrix strategy. I have made the following github action test with the same settings of the original github action (same python versions and same platforms), but the time consumption has dropped from more than 2 hours to less than 25 minutes. Still no cache is used here, maybe the time can be reduced even more!!!

matteo-cristino avatar Sep 16 '22 12:09 matteo-cristino

Build wheels on Ubutnu and Macos inside Build and upload nightly to PyPI can be made less time consuming using parallel computation by expand the matrix strategy. I have made the following github action test with the same settings of the original github action (same python versions and same platforms), but the time consumption has dropped from more than 2 hours to less than 25 minutes. Still no cache is used here, maybe the time can be reduced even more!!!

This is awesome... @albertolerda would you also check the list of all supported platforms, maybe in the last two years they added the arch we are missing for the native python builds, in that case we can proudly say: two pigeons with one fava bean

puria avatar Sep 16 '22 13:09 puria

https://github.com/dyne/Zenroom/pull/486 just made this to speed up my side of things, the -ccache- makefile targets all switch using ccache when installed, plus the meson github actions now adopt the target meson-ccache with a significant speed increase when building

jaromil avatar Sep 19 '22 13:09 jaromil

Screenshot_20220920-210648-770 with ccache now all meson builds and tests take less than 3m 😎

jaromil avatar Sep 20 '22 19:09 jaromil

To skip the CI in PR commits (not to run them per each time) there is a default behaviour described here https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/

puria avatar Sep 23 '22 10:09 puria

can we mark this as resolved?

jaromil avatar Mar 09 '23 02:03 jaromil