Zenroom icon indicating copy to clipboard operation
Zenroom copied to clipboard

Feat/longfellow zk

Open jaromil opened this issue 9 months ago • 1 comments

jaromil avatar May 29 '25 16:05 jaromil

promemoria: introduced minor leaks bypassing openssl on sha256 and in mdoc examples:

Direct leak of 320 byte(s) in 8 object(s) allocated from:
    #0 0x7f571c6b89cf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
    #1 0x5625e6ab6651 in sha256_inc_init(sha256ctx*) util/sha256.cc:265
    #2 0x5625e67db9a0 in proofs::SHA256::SHA256() util/crypto.h:54
    #3 0x5625e67ea99a in proofs::Transcript::Transcript(proofs::SHA256 const&) random/transcript.h:149
    #4 0x5625e67e94f6 in proofs::Transcript::clone() random/transcript.h:80
    #5 0x5625e6827d7a in proofs::ZkProver<proofs::FpGeneric<4ul, true, proofs::Fp256Reduce>, proofs::ReedSolomonFactory<proofs::FpGeneric<4ul, true, proofs::Fp256Reduce>, proofs::FFTExtConvolutionFactory<proofs::FpGeneric<4ul, true, proofs::Fp256Reduce>, proofs::Fp2<proofs::FpGeneric<4ul, true, proofs::Fp256Reduce>, true> > > >::prove(proofs::ZkProof<proofs::FpGeneric<4ul, true, proofs::Fp256Reduce> >&, proofs::Dense<proofs::FpGeneric<4ul, true, proofs::Fp256Reduce> > const&, proofs::Transcript&) zk/zk_prover.h:108
    #6 0x5625e67d3fa3 in run_mdoc_prover circuits/mdoc/mdoc_zk.cc:580
    #7 0x5625e6546386 in mdoc_prove src/zen_longfellow.c:262
    #8 0x5625e657a100 in precallC /home/jrml/devel/zenroom/lib/lua54/src/ldo.c:529
    #9 0x5625e657b3d4 in luaD_precall /home/jrml/devel/zenroom/lib/lua54/src/ldo.c:595
    #10 0x5625e663b8ad in luaV_execute /home/jrml/devel/zenroom/lib/lua54/src/lvm.c:1682
    #11 0x5625e657c208 in ccall /home/jrml/devel/zenroom/lib/lua54/src/ldo.c:637
    #12 0x5625e657c35b in luaD_callnoyield /home/jrml/devel/zenroom/lib/lua54/src/ldo.c:655
    #13 0x5625e655e043 in f_call /home/jrml/devel/zenroom/lib/lua54/src/lapi.c:1038
    #14 0x5625e6572c76 in luaD_rawrunprotected /home/jrml/devel/zenroom/lib/lua54/src/ldo.c:144
    #15 0x5625e657fcce in luaD_pcall /home/jrml/devel/zenroom/lib/lua54/src/ldo.c:957
    #16 0x5625e655e498 in lua_pcallk /home/jrml/devel/zenroom/lib/lua54/src/lapi.c:1064
    #17 0x5625e6489d28 in zen_exec_lua src/zenroom.c:424
    #18 0x5625e654b3f6 in main src/cli-zenroom.c:501
    #19 0x7f571b846249  (/lib/x86_64-linux-gnu/libc.so.6+0x27249)

Direct leak of 227 byte(s) in 6 object(s) allocated from:
    #0 0x7f571c6b89cf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
    #1 0x5625e64841a6 in sfpool_malloc src/sfpool.h:177
    #2 0x5625e64be2e2 in o_new src/zen_octet.c:222
    #3 0x5625e64bf81b in push_string_to_octet src/zen_octet.c:373
    #4 0x5625e6544a27 in mdoc_example src/zen_longfellow.c:117
    #5 0x5625e657a100 in precallC /home/jrml/devel/zenroom/lib/lua54/src/ldo.c:529
    #6 0x5625e657b3d4 in luaD_precall /home/jrml/devel/zenroom/lib/lua54/src/ldo.c:595
    #7 0x5625e663b8ad in luaV_execute /home/jrml/devel/zenroom/lib/lua54/src/lvm.c:1682
    #8 0x5625e657c208 in ccall /home/jrml/devel/zenroom/lib/lua54/src/ldo.c:637
    #9 0x5625e657c35b in luaD_callnoyield /home/jrml/devel/zenroom/lib/lua54/src/ldo.c:655
    #10 0x5625e655e043 in f_call /home/jrml/devel/zenroom/lib/lua54/src/lapi.c:1038
    #11 0x5625e6572c76 in luaD_rawrunprotected /home/jrml/devel/zenroom/lib/lua54/src/ldo.c:144
    #12 0x5625e657fcce in luaD_pcall /home/jrml/devel/zenroom/lib/lua54/src/ldo.c:957
    #13 0x5625e655e498 in lua_pcallk /home/jrml/devel/zenroom/lib/lua54/src/lapi.c:1064
    #14 0x5625e6489d28 in zen_exec_lua src/zenroom.c:424
    #15 0x5625e654b3f6 in main src/cli-zenroom.c:501
    #16 0x7f571b846249  (/lib/x86_64-linux-gnu/libc.so.6+0x27249)
    ```

jaromil avatar Jun 25 '25 12:06 jaromil

🔥

matteo-cristino avatar Jul 04 '25 17:07 matteo-cristino

I will merge this but there will be breakage in the release system, there aren't many other ways for me to try, so I'll do some force push overnight

jaromil avatar Jul 04 '25 17:07 jaromil

If I you need help let me know

matteo-cristino avatar Jul 04 '25 18:07 matteo-cristino