barista
barista copied to clipboard
feat(tag-add): Add possibility to customise add tag button label and …
…overlay header independently.
Pull Request
Motivation: PS-3788
This PR adds possibility to define 'Add tag' and overlay header title independently, as well as making submit button label 'Add' configurable.
After changes:
Please choose the type appropriate for the changes below:
Type of PR
Feature
Checklist
- [x] I have read the CONTRIBUTING doc and I follow the PR guidelines
- [x] Lint and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] I have added necessary documentation (if appropriate)
Thank you for your contribution. Could I bother you by adding an additional example for overriding the labels under libs/examples/src/tag?
Let's say with a name such as tag-override-labels
,
You can see these examples via running npm run demos
.
Thank you for adapting the changes. I have played around with the attributes and we need to truncate the text in the overlay as shown in the following images:
Long titles and buttons are now truncated:
If form is not custom and submit label is too long to be displayed inline, button drops to next line
Thank you for adapting the changes @anntr.
cherry picked into: 10.9.0: 67e399be3b86d86ac229128a8918e397c7a33a27 master: c4e4115f3ca4489dedc6c560dcdffbab75d64adb