barista icon indicating copy to clipboard operation
barista copied to clipboard

feat(tag-add): Add possibility to customise add tag button label and …

Open anntr opened this issue 2 years ago • 5 comments

…overlay header independently.

Pull Request

Motivation: PS-3788

This PR adds possibility to define 'Add tag' and overlay header title independently, as well as making submit button label 'Add' configurable.

After changes: Screenshot 2022-09-29 at 16 29 55 Screenshot 2022-09-29 at 16 30 06


Please choose the type appropriate for the changes below:

Type of PR

Feature

Checklist

  • [x] I have read the CONTRIBUTING doc and I follow the PR guidelines
  • [x] Lint and unit tests pass locally with my changes
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have added necessary documentation (if appropriate)

anntr avatar Sep 29 '22 14:09 anntr

CLA assistant check
All committers have signed the CLA.

dynatrace-cla-bot avatar Sep 29 '22 14:09 dynatrace-cla-bot

Thank you for your contribution. Could I bother you by adding an additional example for overriding the labels under libs/examples/src/tag? Let's say with a name such as tag-override-labels, You can see these examples via running npm run demos.

Sherif-Elhefnawy avatar Oct 05 '22 08:10 Sherif-Elhefnawy

Thank you for adapting the changes. I have played around with the attributes and we need to truncate the text in the overlay as shown in the following images: image image image

Sherif-Elhefnawy avatar Oct 06 '22 07:10 Sherif-Elhefnawy

Long titles and buttons are now truncated: Screenshot 2022-10-08 at 11 10 56

If form is not custom and submit label is too long to be displayed inline, button drops to next line Screenshot 2022-10-10 at 07 20 12

anntr avatar Oct 10 '22 05:10 anntr

Thank you for adapting the changes @anntr.

Sherif-Elhefnawy avatar Oct 17 '22 08:10 Sherif-Elhefnawy

cherry picked into: 10.9.0: 67e399be3b86d86ac229128a8918e397c7a33a27 master: c4e4115f3ca4489dedc6c560dcdffbab75d64adb

Sherif-Elhefnawy avatar Oct 27 '22 10:10 Sherif-Elhefnawy