dymmond
TestClientTransport inherits from wrong base
TestClientTransport is supposed to handle ASGI but inherits from httpx.BaseTransport which is for WSGI and handles with deprecation warnings ASGI.
It should inherit of httpx.AsyncBaseTransport and implement it.
Yes that is correct. For the async client we adopt something else. In fact you are correct. We should implement the AsyncTestClient directly.
We should also deprecate python 3.8 now
Apparently @devkral , httpx is considering releasing 2 different versions. Httpx for sync and async. I'm not sure how that conversation is going yet but there are active conversations. At least as far as I remember, @lovelydinosaur knows more about this.
I'm not saying what we have is wrong but we should have a look at the conversations happening there.