dymint icon indicating copy to clipboard operation
dymint copied to clipboard

refactor(settlement): settlement layer redundent abstraction layer

Open mtsitrin opened this issue 9 months ago • 0 comments

  • merged LayerI and HubClient interfaces in the settlement package there was almost zero common code for base struct, while it created 2 almost identical intrefaces. on the dymension package, with the cosmosClient we had 3(!) interfaces doing basically the same

PR Standards

Opening a pull request should be able to meet the following requirements


Close #629

<-- Briefly describe the content of this pull request -->

For Author:

  • [ ] Targeted PR against correct branch
  • [ ] included the correct type prefix in the PR title
  • [ ] Linked to Github issue with discussion and accepted design
  • [ ] Targets only one github issue
  • [ ] Wrote unit and integration tests
  • [ ] All CI checks have passed
  • [ ] Added relevant godoc comments

For Reviewer:

  • [ ] confirmed the correct type prefix in the PR title
  • [ ] Reviewers assigned
  • [ ] confirmed all author checklist items have been addressed

After reviewer approval:

  • [ ] In case targets main branch, PR should be squashed and merged.
  • [ ] In case PR targets a release branch, PR should be rebased.

mtsitrin avatar May 16 '24 20:05 mtsitrin