dymint icon indicating copy to clipboard operation
dymint copied to clipboard

Avoid local pub sub subscription cancellations

Open danwt opened this issue 9 months ago • 1 comments

When using buffered channels the subscription gets cancelled if the channel gets full

We need to decide on a solution

See https://github.com/dymensionxyz/dymint/pull/773 for discussion and context

cc @omritoptix

danwt avatar May 13 '24 09:05 danwt

just mention that unbuffered channels are still used here https://github.com/dymensionxyz/dymint/blob/94267ae551de46bda60898c23f5092125e60aca6/utils/event/funcs.go#L24, mainly for block received events from p2p. although IMO is better to use unbuffered here to avoid the risk of canceling and therefore stop syncing.

srene avatar May 13 '24 10:05 srene

@srene Do you think we have any more problems stemming from this? Or should we close the issue?

danwt avatar Jan 07 '25 18:01 danwt

i think this can be closed

srene avatar Jan 08 '25 09:01 srene