dymint icon indicating copy to clipboard operation
dymint copied to clipboard

`namespaceID` as a block field is probably redundent

Open mtsitrin opened this issue 9 months ago • 4 comments

Currently, besides the DA's namespace param, which used for blob submission, we also have Namespace field in the block itself.

Seems redundant and unused

mtsitrin avatar May 06 '24 11:05 mtsitrin

@srene do u think it can be removed or we missing something?

mtsitrin avatar May 06 '24 11:05 mtsitrin

it do not see any reason why we need a namespace_id param in the block manager. for da submission it is used the namespace id param from da_config only.

srene avatar May 06 '24 13:05 srene

The namespaceid config parameter is as field used in the block manager, that is actually included in every block header. I would not remove it by now, since modifying header fields can be a critical update

srene avatar May 14 '24 10:05 srene

well we can leave it in the header type, just not fill it if it's unused

mtsitrin avatar May 15 '24 09:05 mtsitrin