dymint icon indicating copy to clipboard operation
dymint copied to clipboard

pass `ctx` to retry.Context(ctx) when calling retry loops

Open mtsitrin opened this issue 10 months ago • 0 comments

          LGTM

not related to this issue, but the context usage is wrong with the retries mechanicm. need to pass the ctx to retry.Context(ctx), instead of

case <-c.ctx.Done():
	c.logger.Debug("Context cancelled")
	return da.ResultCheckBatch{}

Originally posted by @mtsitrin in https://github.com/dymensionxyz/dymint/issues/646#issuecomment-2053731885

mtsitrin avatar Apr 13 '24 18:04 mtsitrin