dymension icon indicating copy to clipboard operation
dymension copied to clipboard

feat: validate posted data to celestia using inclusion proofs #527

Open srene opened this issue 1 year ago • 2 comments

Description

  • PR that adds validation capabilities of batches submitted to celestia for fraud proving.
  • The code includes validation of celestia inclusion proofs and non-inclusion proofs
  • Two new messages are created for non-available batches in celesta or batches committed by the sequencer with mismatching information (wrong commitment)
  • It supports submission of inclusion/non-inclusion proofs for batches submitted by the sequencer using cli and inclusion proofs stored in a json file.

Closes #527

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • [ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • [ ] Targeted PR against the correct branch
  • [ ] included the correct type prefix in the PR title
  • [ ] Linked to the GitHub issue with discussion and accepted design
  • [ ] Targets only one GitHub issue
  • [ ] Wrote unit and integration tests
  • [ ] Wrote relevant migration scripts if necessary
  • [ ] All CI checks have passed
  • [ ] Added relevant godoc comments

SDK Checklist

  • [ ] Import/Export Genesis
  • [ ] Registered Invariants
  • [ ] Registered Events
  • [ ] Updated openapi.yaml
  • [ ] No usage of go map
  • [ ] No usage of time.Now()
  • [ ] Used fixed point arithmetic and not float arithmetic
  • [ ] Avoid panicking in Begin/End block as much as possible
  • [ ] No unexpected math Overflow
  • [ ] Used sendCoin and not SendCoins
  • [ ] Out-of-block compute is bounded
  • [ ] No serialized ID at the end of store keys

Full security checklist here

For Reviewer:

  • [ ] Confirmed the correct type prefix in the PR title
  • [ ] Reviewers assigned
  • [ ] Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • [ ] In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • [ ] In case the PR targets a release branch, PR must be rebased.

srene avatar Feb 22 '24 08:02 srene