dymension icon indicating copy to clipboard operation
dymension copied to clipboard

chore!: change ethermint dependency to evmos repo

Open mtsitrin opened this issue 1 year ago • 2 comments

Description


Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • [ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • [ ] Targeted PR against the correct branch
  • [ ] included the correct type prefix in the PR title
  • [ ] Linked to the GitHub issue with discussion and accepted design
  • [ ] Targets only one GitHub issue
  • [ ] Wrote unit and integration tests
  • [ ] Wrote relevant migration scripts if necessary
  • [ ] All CI checks have passed
  • [ ] Added relevant godoc comments

For Reviewer:

  • [ ] Confirmed the correct type prefix in the PR title
  • [ ] Reviewers assigned
  • [ ] Confirmed all author checklist items have been addressed

After reviewer approval:

  • [ ] In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • [ ] In case the PR targets a release branch, PR must be rebased.

mtsitrin avatar Jan 25 '24 16:01 mtsitrin

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (9c1be1f) 30.87% compared to head (940ae88) 31.07%.

Files Patch % Lines
app/ante/handlers.go 25.00% 24 Missing :warning:
app/ante/ante_options.go 0.00% 2 Missing and 1 partial :warning:
app/ante/ante.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
+ Coverage   30.87%   31.07%   +0.20%     
==========================================
  Files         166      165       -1     
  Lines       25383    25221     -162     
==========================================
+ Hits         7836     7837       +1     
+ Misses      16299    16135     -164     
- Partials     1248     1249       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 04 '24 14:02 codecov[bot]

Blocked by https://github.com/dymensionxyz/evmos/issues/19 https://github.com/dymensionxyz/evmos/issues/16

mtsitrin avatar Feb 07 '24 08:02 mtsitrin