dymension icon indicating copy to clipboard operation
dymension copied to clipboard

feat: streamer should implement the community pool interface

Open mtsitrin opened this issue 1 year ago • 2 comments

PR Standards

Opening a pull request should be able to meet the following requirements:


For Author:

  • [ ] Targeted PR against the correct branch
  • [ ] included the correct type prefix in the PR title
  • [ ] Linked to the GitHub issue with discussion and accepted design
  • [ ] Targets only one GitHub issue
  • [ ] Wrote unit and integration tests
  • [ ] Wrote relevant migration scripts if necessary
  • [ ] All CI checks have passed
  • [ ] Added relevant godoc comments

For Reviewer:

  • [ ] confirmed the correct type prefix in the PR title
  • [ ] Reviewers assigned
  • [ ] confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • [ ] In case it targets the main branch, PR should be squashed and merged.
  • [ ] In case the PR targets a release branch, PR should be rebased.

mtsitrin avatar Nov 29 '23 11:11 mtsitrin

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7b89256) 30.90% compared to head (3b71d6c) 30.90%.

Files Patch % Lines
x/streamer/keeper/community_pool.go 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
- Coverage   30.90%   30.90%   -0.01%     
==========================================
  Files         166      167       +1     
  Lines       25014    25016       +2     
==========================================
  Hits         7730     7730              
- Misses      16045    16047       +2     
  Partials     1239     1239              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 30 '23 11:11 codecov[bot]

will be merged after streamer will support direct funding

mtsitrin avatar Dec 06 '23 13:12 mtsitrin

@mtsitrin can this be closed?

omritoptix avatar Mar 27 '24 12:03 omritoptix