dymension-rdk icon indicating copy to clipboard operation
dymension-rdk copied to clipboard

fix(sequencer): permissioned addresses are not added on genesis

Open srene opened this issue 10 months ago • 1 comments

PR Standards

Opening a pull request should be able to meet the following requirements


Closes #406

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow-up issues.

For Author:

  • [ ] Targeted PR against correct branch
  • [ ] included the correct type prefix in the PR title
  • [ ] Linked to Github issue with discussion and accepted design
  • [ ] Targets only one github issue
  • [ ] Wrote unit and integration tests
  • [ ] All CI checks have passed
  • [ ] Added relevant godoc comments

For Reviewer:

  • [ ] confirmed the correct type prefix in the PR title
  • [ ] Reviewers assigned
  • [ ] confirmed all author checklist items have been addressed

After reviewer approval:

  • [ ] In case targets main branch, PR should be squashed and merged.
  • [ ] In case PR targets a release branch, PR should be rebased.

srene avatar Apr 26 '24 12:04 srene

@srene not sure what it is. can we close this?

omritoptix avatar May 19 '24 16:05 omritoptix

i think this PR was created to solve the issues related with the modifications in https://github.com/dymensionxyz/dymension-rdk/pull/384. The problem afair was that the whitelistedaddresses were not loaded and therefore not possible to create denoms by those. However, i think those modifications were reverted before nim rollap release, but not sure what is the status of it now.

srene avatar May 21 '24 07:05 srene

I close this PR since it is not relevant anymore

srene avatar May 21 '24 14:05 srene