with `lazy loading` on, display names are broken in group chats

[petermolnar]

example:

(2021-06-29 08:48:56) WFPTMD7J6: [edit] ⤷ 07:47:00 AM:
[...]
(2021-06-29 08:54:34) WFQ44TVKP: > `()()` is not a palindrome, but `)(()` is.

Note: I'm on an enterprise slack, that might matter.

How can I help trying to find a fix for this?

[dylex]

It may be (looking back) that this was never actually implemented. It would probably help to start by understanding the scope of the problem. Do IMs show up with usernames? Similarly, if you get an IM from someone, does their name now show up correctly in channels? Do they show up correctly other places?

If things are how I suspect, I should be able to fix it, but just want to make sure I'm looking the right place, first. (Basically slack_handle_message doesn't do anything to lookup the user if we don't know it. I think the best place to fix this is in slack_conversation_retrieve, which currently does the user lookup only for IMs, but should really just lookup both the conversation and then the sender separately.)

(There's this whole other issue about federated slacks that is also broken, but I presume that's not the case here.)

[djha-skin]

The time I was able to log in without lazy loading enabled, I was able to see all the users in the room, and all the display names worked properly in the room (for example, in the general channel). This is how it looks with lazy loading enabled. https://i.imgur.com/pk6nXpv.png