flutter-cupertino-date-picker icon indicating copy to clipboard operation
flutter-cupertino-date-picker copied to clipboard

AM/PM - 12 hour time picker

Open JamesMcIntosh opened this issue 4 years ago • 8 comments

Fixes issue #35

I have tested the code in time_picker_widget.dart

I ported the code from time_picker_widget.dart across into datetime_picker.dart

JamesMcIntosh avatar Sep 06 '19 14:09 JamesMcIntosh

@radvansky-tomas I've updated my PR with code formatting and the couple of changes you made, I did notice that in your branch you reverted DateTimePickerWidget._changeMinuteSelection change which I think will now break when minutes are divided into intervals.

JamesMcIntosh avatar Oct 11 '19 04:10 JamesMcIntosh

@JamesMcIntosh I am not aware of any revert, I simply took latest version and added AM/PM like you did, for my personal project. If there are any bugs / missing parts...feel free to fix / change that. Once I see that is merged and stable enough I will switch back from my fork ;)

rdev-software avatar Oct 20 '19 20:10 rdev-software

Hi @dylanwuzh, just wondering if you are going to test/ review this pull request? I'm not actively using this library at the moment but and happy to finish getting this pull request merged into your source if you have any feedback.

JamesMcIntosh avatar Dec 19 '19 23:12 JamesMcIntosh

I don't know why such a feature isn't merged yet! I want it badly.

shadyshrif avatar Jan 03 '20 16:01 shadyshrif

@dylanwuzh LGTM :)

jamesdixon avatar Jan 12 '20 04:01 jamesdixon

Sorry guys bit busy and sick lately. Feel free you use my codes, as I said before I am not aware of any reverts I did during dev. So test it and let me know if it broke something.

rdev-software avatar Jan 12 '20 05:01 rdev-software

For me, I used this lite plugin for time selection until that pull request is merged and the plugin is updated.

https://github.com/icemanbsi/flutter_time_picker_spinner

shadyshrif avatar Jan 12 '20 09:01 shadyshrif

@dylanwuzh Are you going to merge this PR?

JamesMcIntosh avatar Nov 24 '20 04:11 JamesMcIntosh