curvipy icon indicating copy to clipboard operation
curvipy copied to clipboard

A rotation function

Open astro-ray opened this issue 2 years ago • 2 comments

A function that rotates the curve by a certain $\theta$ angle. The implementation is easy, it will take $\theta$, and the curve as input, and method is just like TransformedCurve, but the matrix used will be:

$$A(\theta)=\begin{pmatrix} \cos\theta & -\sin\theta\ \sin\theta & \cos\theta \end{pmatrix}$$

astro-ray avatar Dec 12 '22 12:12 astro-ray

Hey @ritamsaha00, thanks for opening an issue!

Originally (on version 0.1.1 and below), curvipy provided a RotatedCurve class. On curvipy 1.0.0, when I reorganized the whole structure of curvipy, I decided to remove this class because it's not part of the core of curvipy, since it can easily be defined using the 'curvipy.TransformedCurve' class.

Anyways, I think it might be a good idea to create a subpackage where we can develop more specific curves and vectors, such as the rotation function you proposed. Let me know what you think about this, and tell me if you came up with an idea of what to name this subpackage and its modules!

dylannalex avatar Dec 12 '22 15:12 dylannalex

Hello @dylannalex , I have been thinking about the name of a subpackage and what could go in it. I think there can be a sub-package called specialOperation where we could have modules like rotation and Fourier etc. ( I have only thought about these two modules for the time being ). What do you think about this approach?

astro-ray avatar Dec 20 '22 15:12 astro-ray