dinosaur-exploder icon indicating copy to clipboard operation
dinosaur-exploder copied to clipboard

feat: add the ability to turn on/off sound

Open Halloween5 opened this issue 1 year ago β€’ 3 comments

πŸ‘‰ Checklist

Please make sure to check off the following before submitting:

  • [ ] I have reviewed my submission thoroughly.
  • [ ] I have tested my code (if submission is related to coding) and run the game before pushing (to make sure the project compile).
  • [ ] I have run the JUnit tests (if submission is related to coding).
  • [ ] I have read the Code of Conduct and Contribution Guidelines.

✍ Description of the Pull Request

Please concisely describe the changes you have made.

What?

  • I add the ability to turn off sound.

Why?

  • I noticed the project's issue on sound issues.

How?

  • I set a variable to record a soundbutton click event and control the background music. I store this variable locally.

πŸ”— Issue link

Issue reference number and link goes here e.g. 'Fixes/Closes #<issue_number>'.

  • [ ] This Pull Request fixes the issue : 'Closes #'
  • [ ] This Pull Request does not fix an issue.

Thanks for taking the time to fill out this Pull Request! ❀️ Thanks for contributing to this project πŸ¦–

Halloween5 avatar Jul 04 '23 10:07 Halloween5

Please next time, can you fill out the PR template by checking/unchecking the different boxes ?

jvondermarck avatar Jul 04 '23 20:07 jvondermarck

ok, thank you

Halloween5 avatar Jul 06 '23 16:07 Halloween5

@Halloween5 if you need any help doing that, do not hesitate to ask for help, I'm here ! ☺️

jvondermarck avatar Jul 06 '23 16:07 jvondermarck

Won't fix, too old. Please submit another new PR if needed. Sorry.

jvondermarck avatar Aug 26 '24 20:08 jvondermarck