opendylan icon indicating copy to clipboard operation
opendylan copied to clipboard

doc: Broken link to DRM specific examples of module import

Open fraya opened this issue 1 year ago • 1 comments

Broken link to https://opendylan.org/books/drm/Definition_Macros#IX-2017

https://github.com/dylan-lang/opendylan/blob/f546cf1d7adec5db780fbbbc47b074509730d400/documentation/source/intro-dylan/modules-libraries.rst?plain=1#L64

fraya avatar Jun 01 '24 12:06 fraya

huh. I could've sworn spaces were replaced by underscores in DRM references. I guess not!

cgay avatar Jun 02 '24 14:06 cgay

I think the problem is in the regular expression of sphinx-extensions

https://github.com/dylan-lang/sphinx-extensions/blob/dac8163efe0f2b44264bf06813a797ff6b4ba036/sphinxcontrib/dylan/domain/dylandomain.py#L38

It matches everything Image

Image

It should be replaced by:

Image

Image

that works for this case

<a class="reference external" href="[https://opendylan.org/books/drm/Definition_Macros#define_module](view-source:https://opendylan.org/books/drm/Definition_Macros#define_module)"><code class="xref drm docutils literal notranslate"><span class="pre">specific</span> <span class="pre">examples</span></code></a>

I need to check if it breaks another link.

fraya avatar Apr 11 '25 17:04 fraya