system, io, common-dylan test suites are interdependent

[cgay]

Both the system and io test suites import common-dylan-test-suite. They do this to get the "stream testing protocol", apparently, based on a comment at the import site. That protocol should be in a separate library so that the entire common-dylan test suite doesn't need to be used.

In the new testworks regime, where all tests are registered at library load time, importing another test suite has the result that running "all" the tests in the system test suite runs the common-dylan tests as well. That is, run-test-application() with no args runs all registered tests and run-test-application(system-test-suite) just runs the system tests.

In addition to the above, there are some tests that are in the wrong test suite. e.g., the test for application-name() is in operating-system even though it's defined in common-dylan. I suspect the below may be another one, although I haven't looked closely yet:

system-test-suite failed
  file-system-module-test-suite failed
    file-system-protocol-test-suite failed
      file-system-protocol-classes-test failed
        make <file-stream> with required arguments crashed [Error evaluating assertion expressions:
 Assertion failed: Making test instance of unregistered stream class {<class>: <file-stream>}]
        The variable <file-system-directory-locator> is a class failed [expression "#f" evaluates to #f.]
        The variable <file-system-file-locator> is a class failed [expression "#f" evaluates to #f.]

Also also, including the entire common-dylan-test-suite slows compilation of the system and io suites when you're trying to work on them separately.

[cgay]

Also also also, common-dylan-test-suite includes dylan-test-suite, I assume for similar reasons.

[cgay]

I believe this is done.